[PATCH] D108223: gn build: Build libclang.so on ELF platforms.

[Nico Weber via Phabricator via cfe-commits]

thakis added a comment.

Hm, I kind of like the PIC-less build. But probably not worth having a toggle for it, I suppose. So lg, but:



================
Comment at: llvm/utils/gn/secondary/clang/tools/libclang/BUILD.gn:16
-  # For now, make libclang a static lib there.
-  libclang_target_type = "static_library"
-} else {
----------------
probably should update these too:

```
% rg -F 'rget_type = "static_librar' llvm/utils/gn
llvm/utils/gn/secondary/compiler-rt/lib/tsan/BUILD.gn
12:  tsan_target_type = "static_library"

llvm/utils/gn/secondary/compiler-rt/lib/asan/BUILD.gn
12:  asan_target_type = "static_library"

llvm/utils/gn/secondary/clang/tools/libclang/BUILD.gn
16:  libclang_target_type = "static_library"

llvm/utils/gn/secondary/llvm/tools/lto/BUILD.gn
8:  lto_target_type = "static_library"
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108223/new/

https://reviews.llvm.org/D108223