[PATCH] D108083: [PATCH 1/8] [sanitizer] Add hexagon support to sanitizer-common

[Brian Cain via Phabricator via cfe-commits]

bcain added inline comments.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_stacktrace.cpp:25
   return pc + 8;
-#elif defined(__powerpc__) || defined(__arm__) || defined(__aarch64__)
+#elif defined(__powerpc__) || defined(__arm__) || defined(__aarch64__) \
+  || defined(__hexagon__)
----------------
bcain wrote:
> vitalybuka wrote:
> > but please fix ones like this which do not require significant reformatting of unchanged code.
> Ok that's no problem.
>> but please fix ones like this which do not require significant reformatting of unchanged code.
> Ok that's no problem.

But it's a little odd -- following the format would pull the `or` operator onto the previous line, which would deviate from the style used in the rest of the file.

Still happy to make the change, it just doesn't seem like it fits.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108083/new/

https://reviews.llvm.org/D108083