[PATCH] D105167: [analyzer] Fix HTML report deduplication.

[Denys Petrov via Phabricator via cfe-commits]

ASDenysPetrov accepted this revision.
ASDenysPetrov added a comment.

Nice work! Unfortunately I'm not able to run tests on my Windows env, but I've run you tests files manually. It works for me.

P.S. BTW, is there any workarounds to make current tests supported on Windows? I know there is //REQUIRES// instruction (https://llvm.org/docs/TestingGuide.html#constraining-test-execution) but I didn't a sufficient description of it.



================
Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:286-287
+  // but the stable report filename is still more verbose.
+  // We should rename the option ("verbose" filename?) but it will break
+  // people's workflows.
+  if (DiagOpts.ShouldWriteStableReportFilename) {
----------------
vsavchenko wrote:
> Can we make a mirror for this option and mark the other one as deprecated?
Nice idea. I'm in favor of a mirorring.


================
Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:300
+
+  filename << StringRef(getIssueHash(D, PP)).substr(0, 6).str() << ".html";
+  llvm::sys::path::append(ResultPath, Directory, filename.str());
----------------
Do you think 6 trimmed characters are enough to avoid collisions?


Repository:
  rC Clang

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105167/new/

https://reviews.llvm.org/D105167