[PATCH] D108029: [clang][Codegen] Introduce the disable_sanitizer_instrumentation attribute

[Marco Elver via Phabricator via cfe-commits]

melver added inline comments.


================
Comment at: llvm/include/llvm/IR/Attributes.td:90
+/// Do not instrument function with sanitizers.
+def DisableSanitizerInstrumentation: EnumAttr<"disable_sanitizer_instrumentation", [FnAttr]>;
+
----------------
There's this long-tail of changes required for adding new keywords to the IR. Have a look at https://reviews.llvm.org/D102772 -- things that I see currently missing are various tests etc.


================
Comment at: llvm/lib/Bitcode/Writer/BitcodeWriter.cpp:631
     return bitc::ATTR_KIND_COLD;
+  case Attribute::DisableSanitizerInstrumentation:
+    return bitc::ATTR_DISABLE_SANITIZER_INSTRUMENTATION;
----------------
There's also BitcodeReader, which needs something similar.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108029/new/

https://reviews.llvm.org/D108029