[PATCH] D105426: [clangd] IncludeCleaner as a library: Find all references to symbols in the file

[Sam McCall via Phabricator via cfe-commits]

sammccall accepted this revision.
sammccall added inline comments.
This revision is now accepted and ready to land.


================
Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:65
+  bool VisitExpr(Expr *E) {
+    TraverseType(E->getType());
+    return true;
----------------
I just realized this uses "T" if any expression has type "T*" even if never dereferenced, this is probably a gross overestimate. Nevertheless I guess fine for now.


================
Comment at: clang-tools-extra/clangd/IncludeCleaner.cpp:101
+
+// Given a set of referenced FileIDs, determines all the potentially-referenced
+// files and macros by traversing expansion/spelling locations of macro IDs.
----------------
this struct is not used in this patch


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105426/new/

https://reviews.llvm.org/D105426