[PATCH] D106891: [Remarks] Emit optimization remarks for atomics generating CAS loop

Stanislav Mekhanoshin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 16 10:23:32 PDT 2021


rampitec added inline comments.


================
Comment at: llvm/lib/CodeGen/AtomicExpandPass.cpp:175
 
+  ORE = std::make_unique<OptimizationRemarkEmitter>(&F);
   auto &TM = TPC->getTM<TargetMachine>();
----------------
Is there a reason to construct it upfront and not just use a local variable only when needed? Like in StackProtector.cpp for example.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106891/new/

https://reviews.llvm.org/D106891



More information about the cfe-commits mailing list