[PATCH] D105821: [analyzer] [WIP] Model destructor for std::unique_ptr
Artem Dergachev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 16 08:23:11 PDT 2021
NoQ added a comment.
The code looks great, I don't see any major problems.
We still need tests, I can't stress this enough. All the real-world cornercases you've covered here as you updated the patch deserve a test case.
Some of these changes should probably be separated into other patches, eg. invalidation and pointer escape for non-destructor operations.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D105821/new/
https://reviews.llvm.org/D105821
More information about the cfe-commits
mailing list