[PATCH] D104975: Implement P1949

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: clang/lib/Lex/Lexer.cpp:1622-1623
+
+  const bool isIDStart = isAllowedInitiallyIDChar(CodePoint, LangOpts);
+  const bool isIDContinue = isIDStart || isAllowedIDChar(CodePoint, LangOpts);
+
----------------



================
Comment at: clang/lib/Lex/Lexer.cpp:1628
+
+  const bool InvalidOnlyAtStart = IsFirst && !isIDStart && isIDContinue;
+
----------------



================
Comment at: clang/lib/Lex/Lexer.cpp:1687-1689
+  if (Result != llvm::conversionOK) {
     return false;
+  }
----------------



================
Comment at: clang/lib/Lex/Lexer.cpp:1698-1700
+    // We got a unicode codepoint that is neither a space nor a
+    // a valid identifier part
+    // Carry on as if the codepoint was valid for recovery purposes
----------------



================
Comment at: clang/www/make_cxx_dr_status:139
+    if dup.startswith('P'):
+      avail = 'Superseded by <a href="wg21.link/%s">%s</a>' % (dup, dup)
+      avail_style = ' class="na"'
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104975/new/

https://reviews.llvm.org/D104975