[PATCH] D108110: Fix LLVM_ENABLE_THREADS check from 26a92d5852b2c6bf77efd26f6c0194c913f40285

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 16 06:07:43 PDT 2021


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM!

> Since the other branch has never been used I wonder if we should just remove it instead?

I don't think removing the other branch entirely is a good approach because then the call will silently be a noop when threads are disabled. I'd rather we keep the support, or turn the other branch into a loud breakage so that callers of it find out at compile time that it's not supported when threads are disabled.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108110/new/

https://reviews.llvm.org/D108110



More information about the cfe-commits mailing list