[PATCH] D108083: add sanitizer support to hexagon

[Brian Cain via Phabricator via cfe-commits]

bcain added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/Hexagon.cpp:297-298
+        linkSanitizerRuntimeDeps(HTC, CmdArgs);
+        // FIXME: sanitizer_common or only some require unwind?
+        CmdArgs.push_back("-lunwind");
+      }
----------------
I will try to determine which sanitizers require libunwind so that it's only added when appropriate.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_linux.cpp:162
+#elif SANITIZER_LINUX && defined(__hexagon__)
+#include "sanitizer_syscall_linux_hexagon.inc"
 #else
----------------
Most of the feedback from `clang-format` checks don't seem to really be the format we use here.  We should probably apply a more specific `.clang-format` file if these aren't useful.


================
Comment at: compiler-rt/lib/sanitizer_common/sanitizer_syscall_linux_hexagon.inc:124
+
+bool internal_iserror(uptr retval, int *rverrno) {
+  if (retval == (uptr)-1) {
----------------
@sidneym Can you confirm that this implementation looks correct?  I thought the convention was -1 for failed syscalls.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108083/new/

https://reviews.llvm.org/D108083