[PATCH] D54943: [clang-tidy] implement const-transformation for cppcoreguidelines-const-correctness

[Jonas Toth via Phabricator via cfe-commits]

JonasToth added a comment.

The check in the latest form can properly transform `llvm/lib` and `clang/` and requires 28 manual fixes afterwards (values and references are transformed, no other modifications).
 Some are good and not an issue with the analysis itself, some may or may not be an issue with the analysis itself. I think it is more a template meta programming thing.

Here is the branch that contains the changes: https://github.com/JonasToth/llvm-project/tree/transformation/2021-august-15-revision2

Short Stats:

- llvm/lib transformation: `1724 files changed, 62110 insertions(+), 62110 deletions`; `26 manual fixes`
- clang/ transformation: `819 files changed, 24166 insertions(+), 24166 deletions`; `2 manual fixes`, one fix solves a ternary-operator issue where only one branch got `const`, the other one adds default construction

I consider all 27 of them as false positives, but they might be bad const-correctness of the library code as well.
Thats good enough?

@0x8000-0000 @tiagoma If you have time it would be great if you could check the transformation on your code bases.
Everyone else is welcome to try it out too!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D54943/new/

https://reviews.llvm.org/D54943