[PATCH] D107873: [WIP][clang-tidy] adds a const-qualified parameter check

[Christopher Di Bella via Phabricator via cfe-commits]

cjdb marked an inline comment as done.
cjdb added a comment.

@jmarrec I believe you wanted to import a discussion from D107900 <https://reviews.llvm.org/D107900>?



================
Comment at: clang-tools-extra/clang-tidy/performance/ConstParameterValueOrRef.cpp:57
+namespace {
+bool isSharedPtr(const QualType &T) {
+  if (auto R = T->getAsCXXRecordDecl())
----------------
Eugene.Zelenko wrote:
> Please use `static`, not anonymous namespace for functions.
Hmm... there are lots of instances of `namespace {` in clang-tidy.


================
Comment at: clang-tools-extra/docs/clang-tidy/checks/performance-const-parameter-value-or-ref.rst:104
+various `boards <https://git.io/JRKGv>`_. The benchmark can be found on
+`Compiler Explorer <https://godbolt.org/z/rfW1Wqajh>`_, with the used to inform
+the threshold.
----------------
jmarrec wrote:
> typo here, not sure what the intent was.
I think this is something I put at the end first, and then moved to the start of the sentence, but forgot to delete.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107873/new/

https://reviews.llvm.org/D107873