[PATCH] D107933: [clang] Expose unreachable fallthrough annotation warning

Nathan Chancellor via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 13 15:30:21 PDT 2021


nathanchance marked an inline comment as done.
nathanchance added inline comments.


================
Comment at: clang/test/SemaCXX/switch-implicit-fallthrough.cpp:211-214
+    case 224:
+      n += 400;
+    case 225: // expected-warning{{unannotated fall-through between switch labels}} expected-note{{insert '[[clang::fallthrough]];' to silence this warning}} expected-note{{insert 'break;' to avoid fall-through}}
+        ;
----------------
nickdesaulniers wrote:
> These 4 lines don't add anything to the test coverage.  Remove them?
Done.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107933/new/

https://reviews.llvm.org/D107933



More information about the cfe-commits mailing list