[PATCH] D107961: [clang-format] Distinguish K&R C function definition and attribute

Fri Aug 13 13:26:26 PDT 2021

owenpan marked 3 inline comments as done.
owenpan added inline comments.

================
Comment at: clang/lib/Format/UnwrappedLineParser.cpp:17
 #include "FormatToken.h"
-#include "clang/Basic/TokenKinds.h"
 #include "llvm/ADT/STLExtras.h"
----------------
HazardyKnusperkeks wrote:
> owenpan wrote:
> > HazardyKnusperkeks wrote:
> > > Why is this not needed anymore?
> > It was added in [[ https://reviews.llvm.org/D107950 | D107950 ]] but not needed even there.
> I would put that in a different commit, it has nothing to do with what is changed here. And the revert is the example why I would put that in different commits. :)
> 
> But I will not stand in the way to land this.
I included the test case here though. It's related to the bug I had in previous diffs.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107961/new/

https://reviews.llvm.org/D107961