[PATCH] D107893: [clang] [MinGW] Consider the per-target libc++ include directory too

Fri Aug 13 11:48:08 PDT 2021

zero9178 added a comment.

In D107893#2944193 <https://reviews.llvm.org/D107893#2944193>, @mstorsjo wrote:

> In D107893#2943679 <https://reviews.llvm.org/D107893#2943679>, @zero9178 wrote:
>
>> Any chance this patch could be backported onto the LLVM 13 branch? I have been using a per target runtime builds for a few versions now but the functionality has regressed in LLVM 13, which would force me back into a normal single target layout.
>
> I presume this should be pretty trivial to backport yes - can you file a bug about it in bugzilla, CC @tstellar and mark it as blocking the 13.0.0 release bug?
>
> In which way was this a regression - I guess clang didn't change here - did libcxx start installing the `__config_site` file differently during this release?

Since this release libc++ splits what was previously the `__config` header into `__config_site` and `__config`, where `__config_site` contains all the defines set at configure time by CMake and gets included by `__config`. Without this patch the include path to `__config_site`s directory is missing in per target builds and therefore including any file of libc++ causes a compilation error.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107893/new/

https://reviews.llvm.org/D107893