[PATCH] D106215: Make wide multi-character character literals ill-formed in C++ mode

Fri Aug 13 06:08:05 PDT 2021

cor3ntin added a comment.

In D106215#2943611 <https://reviews.llvm.org/D106215#2943611>, @aaron.ballman wrote:

> I think that C and C++ should behave the same here; at least, I don't see any reason why they should have different capabilities.

I agree but as WG14 hasn't weighted in I didn't want to make that call.
What do you think?

> The paper said that there is no expected code breakage from this change, but have you tried building a diverse corpus of code (like a distro's worth of packages) under this patch to see if anything actually breaks in practice? (I don't expect breakage that isn't identifying an actual issue in the code, but having some verification would be appreciated.) This would also help to identify whether the change is appropriate for C as well.

We have done regexes over various repositories (every vcpkg package) with no match. Not running a complete compiler

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106215/new/

https://reviews.llvm.org/D106215