[PATCH] D105168: [RISCV] Unify the arch string parsing logic to RISCVISAInfo.

Kito Cheng via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 12 02:20:28 PDT 2021


kito-cheng updated this revision to Diff 365941.
kito-cheng added a comment.

Changes:

- Rename class, strip the `Info`:
  - `RISCVSupportedExtensionInfo` -> `RISCVSupportedExtension`
- Rename variables:
  - `SupportedExtensionInfos` -> `SupportedExtensions`
  - `SupportedExperimentalExtensionInfos` -> `SupportedExperimentalExtensions`
- Change return type of parseArchString to `llvm::Expected<std::unique_ptr<RISCVISAInfo>>`
- Address @jrtc27's comment.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105168/new/

https://reviews.llvm.org/D105168

Files:
  clang/lib/Basic/Targets/RISCV.cpp
  clang/lib/Basic/Targets/RISCV.h
  clang/lib/Driver/ToolChains/Arch/RISCV.cpp
  clang/test/Driver/riscv-abi.c
  clang/test/Driver/riscv-arch.c
  llvm/include/llvm/Support/RISCVISAInfo.h
  llvm/lib/Support/CMakeLists.txt
  llvm/lib/Support/RISCVISAInfo.cpp
  llvm/lib/Target/RISCV/AsmParser/RISCVAsmParser.cpp
  llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.cpp
  llvm/lib/Target/RISCV/MCTargetDesc/RISCVBaseInfo.h
  llvm/lib/Target/RISCV/MCTargetDesc/RISCVTargetStreamer.cpp
  llvm/test/MC/RISCV/attribute-arch.s
  llvm/test/MC/RISCV/attribute-with-insts.s
  llvm/test/MC/RISCV/invalid-attribute.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105168.365941.patch
Type: text/x-patch
Size: 74031 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210812/a2efcb40/attachment-0001.bin>


More information about the cfe-commits mailing list