[PATCH] D107095: Implement #pragma clang header_unsafe

[Chris Bieneman via Phabricator via cfe-commits]

beanz added a reviewer: lebedev.ri.
beanz added a subscriber: lebedev.ri.
beanz added a comment.

+ at lebedev.ri

@aaron.ballman thank you for all the feedback and support!

I'm not really sure where to go on the naming. I'm not attached to `header_unsafe`, and totally understand the confusion. I don't really love the `reserved*` wording either as it doesn't really convey meaning.

For my other patch I like `final` because it means something similar to what the `final` keyword means in C++ and other languages (i.e. don't change this again).

For this I also thought about variations on `restrict` to signify restrictions on the macro's expansion contexts.

The goal is to warn on expansions that are outside the main source file, so maybe something like `restrict_header_expansion`?

Very open to feedback here on making clear naming. After all naming is one of the hardest problems in computer science :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107095/new/

https://reviews.llvm.org/D107095