[PATCH] D107876: [CSSPGO] Allow the use of debug-info-for-profiling and pseudo-probe-for-profiling together

Hongtao Yu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 10 18:21:25 PDT 2021


hoy created this revision.
Herald added subscribers: modimo, wenlei.
hoy requested review of this revision.
Herald added projects: clang, LLVM.
Herald added subscribers: llvm-commits, cfe-commits.

Previoulsy debug-info-for-profiling and pseudo-probe-for-profiling are mutual exclusive because they compete the dwarf discrimnator for callsites on the IR. This changes allows to use the two switches together. The side effect is that callsite discriminators will be taken by pseudo probe, while discriminators for other instructions are still available for AutoFDO use. This is less than ideal, however, it still allows us a chance to smoothly transition from AutoFDO to CSSPGO, by collecting both profiles from a CSSPGO binary.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D107876

Files:
  clang/lib/Driver/ToolChains/Clang.cpp
  clang/test/CodeGenCXX/fdebug-info-for-profiling.cpp
  clang/test/Driver/pseudo-probe.c
  llvm/include/llvm/Passes/PassBuilder.h
  llvm/test/Transforms/SampleProfile/pseudo-probe-discriminator.ll
  llvm/tools/opt/NewPMDriver.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107876.365638.patch
Type: text/x-patch
Size: 8938 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210811/65e91ab9/attachment.bin>


More information about the cfe-commits mailing list