[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

Matt Jacobson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 9 21:00:54 PDT 2021


mhjacobson added a comment.

In D107684#2936033 <https://reviews.llvm.org/D107684#2936033>, @MaskRay wrote:

> `--sysroot %S/Inputs/basic_avr_tree/usr/lib` seems incorrect.
>
> sysroot is usually a directory which contains `usr/lib` and `lib/`. `somewhere/usr/lib` is not usually used as a sysroot.

Yeah, I agree it's weird.  This is basically a shortcut to avoid creating a duplicate sysroot in `Inputs`.  Would you prefer I create the duplicate tree?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107684/new/

https://reviews.llvm.org/D107684



More information about the cfe-commits mailing list