[PATCH] D107786: [AIX]: Fix option processing for -b
Hubert Tong via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 9 16:12:18 PDT 2021
hubert.reinterpretcast added inline comments.
================
Comment at: clang/lib/Driver/ToolChains/CommonArgs.cpp:271
// Handle reserved library options.
- if (A.getOption().matches(options::OPT_Z_reserved_lib_stdcxx))
+ else if (A.getOption().matches(options::OPT_Z_reserved_lib_stdcxx))
TC.AddCXXStdlibLibArgs(Args, CmdArgs);
----------------
Can we move the `OPT_b` block above into the if-else chain after the `OPT_z` case? The `else` occurring after the comment strikes me as being very unfortunate code formatting.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107786/new/
https://reviews.llvm.org/D107786
More information about the cfe-commits
mailing list