[PATCH] D107242: [AIX] Define __HOS_AIX__ macro

Chris Bowler via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 9 12:37:59 PDT 2021


cebowleratibm added a comment.

In D107242#2934611 <https://reviews.llvm.org/D107242#2934611>, @joerg wrote:

> clang is fundamentally a cross-compiler only. I don't see any point for having host-specific branches in this case at all. Either the macro should be specified for the target all the time or not at all, but it should most definitely not depend on the host. That's actually breaking a number of existing use case for clang in subtle ways, e.g. partially preprocessed files (`-frewrite-includes`) should behave the same on any platform given the same command line.

Given that we have a legacy XL macro with no legacy cross compiler I think it's fine if we set this according to the target only.  It's fully redundant to `_AIX ` but we'll define it for any working use-case with the current xlC compiler.  If IBM has a compelling use case for a host-specific macro we can always revive this discussion.  For now, you're probably making us from making a mistake ;)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107242/new/

https://reviews.llvm.org/D107242



More information about the cfe-commits mailing list