[PATCH] D69764: [clang-format] Add East/West Const fixer capability

Mon Aug 9 08:27:02 PDT 2021

erichkeane added a comment.

In D69764#2934646 <https://reviews.llvm.org/D69764#2934646>, @MyDeveloperDay wrote:

>> I find it weird that we aren't handling ALL of the CV qualifiers.
>
> I will probably try and address this, I do have some ideas, but this will I believe complicate the implementation. For now I really want to understand if conceptually such a feature can be landed, not so much land it in entirely this form. if I can get some agreement and that really means that people need to generally be in agreement.

Understood.

>> From a "we should be inclusive" perspective, my understanding is that east==right, west==left is considered by some to be euro-centric due to its north-up bias. I don't feel strongly about it, but it at least gives me a somewhat significant preference for left/right vs east/west.
>
> I think this is partially historical because I was following the whole east const vs west const (https://github.com/isocpp/CppCoreGuidelines/blob/master/CppCoreGuidelines.md#Rl-const,https://mariusbancila.ro/blog/2018/11/23/join-the-east-const-revolution/, https://www.youtube.com/watch?v=fv--IKZFVO8). I don't have a problem supporting one/both or either, I tend to think that is more arguing semantics.
>
> After seeing those videos I wanted clang-format to end the east vs west war, like clang-format ended the whitespace war!,.... I didn't realise I'd cause a clang war in the process! oops!! ;-)

I understand the origin of east/west in this case, I was around when those bracelets came out :)  Someone internally pointed out the anti-inclusivity of the terminology, so I figured I'd bring it up.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69764/new/

https://reviews.llvm.org/D69764