[PATCH] D107718: [cuda] Mark builtin texture/surface reference variable as 'externally_initialized'.
Yaxun Liu via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 9 06:56:11 PDT 2021
yaxunl added inline comments.
================
Comment at: clang/lib/CodeGen/CodeGenModule.cpp:4441
if (Linkage != llvm::GlobalValue::InternalLinkage &&
- (D->hasAttr<CUDADeviceAttr>() || D->hasAttr<CUDAConstantAttr>()))
+ (D->hasAttr<CUDADeviceAttr>() || D->hasAttr<CUDAConstantAttr>() ||
+ D->getType()->isCUDADeviceBuiltinSurfaceType() ||
----------------
we need also do this with variables with HIPManagedAttr and add a test for that
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107718/new/
https://reviews.llvm.org/D107718
More information about the cfe-commits
mailing list