[PATCH] D69764: [clang-format] Add East/West Const fixer capability

[Erich Keane via Phabricator via cfe-commits]

erichkeane requested changes to this revision.
erichkeane added a comment.
This revision now requires changes to proceed.

I've just been watching this from the sideline, but the cases where this breaks code are unacceptable for this tool, it is a complete direction change for the tool, and making that direction change silently on a review of a 15 month patch, where TWO code owners have said 'no' for that reason is absurd.

I use this tool daily as a part of my 'upload' script, having it silently bust code between when I validate it and when I upload it is terrible, and makes the tool unusable for my purposes.  If we change this direction without a full RFC, my next step is going to be an RFC to remove clang-format from the check-in requirements of the entire LLVM project.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69764/new/

https://reviews.llvm.org/D69764