[PATCH] D107078: [analyzer] Catch leaking stack addresses via stack variables

[Balázs Benics via Phabricator via cfe-commits]

steakhal updated this revision to Diff 365133.
steakhal marked 2 inline comments as done.
steakhal added a comment.

Removed the extra note about the temporary expression.

---

In D107078#2933682 <https://reviews.llvm.org/D107078#2933682>, @NoQ wrote:

> In D107078#2927899 <https://reviews.llvm.org/D107078#2927899>, @steakhal wrote:
>
>> I did not fix the extra blue 'bubble' note issue, and I think that is out of the scope of this patch.
>
> This is an on-by-default checker. We should not knowingly regress it, even if temporarily.

I'm not exactly sure what would I regress, but to be on the safe side I won't emit any extra notes this time.

WDYT about the current form?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107078/new/

https://reviews.llvm.org/D107078

Files:
  clang/lib/StaticAnalyzer/Checkers/StackAddrEscapeChecker.cpp
  clang/test/Analysis/copy-elision.cpp
  clang/test/Analysis/cxx-uninitialized-object-ptr-ref.cpp
  clang/test/Analysis/loop-block-counts.c
  clang/test/Analysis/stack-addr-ps.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107078.365133.patch
Type: text/x-patch
Size: 14608 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210809/4b81e81b/attachment-0001.bin>