[PATCH] D105426: [clangd] IWYU as a library: Find all references to symbols in the file

[Kirill Bobyrev via Phabricator via cfe-commits]

kbobyrev updated this revision to Diff 365094.
kbobyrev marked 15 inline comments as done.
kbobyrev added a comment.

Thank you for the great suggestions! Indeed, we already have the confusion
regarding IWYU having the CLI flag and users are thinking we provide some sort
of integration/implementation. Having even more confusion (implementing
similar) functionality for our needs is not what we want (also, apologies for
confusion,"as a library" was more about the patch in this context - meaning not
a "usable" feature yet but a smaller scope where we just start the
implementation as the library that can only be used in tests for now). Hence,
renamed the feature to "Include Sanity" (close to Include Hygiene but sounds
better IMO, please let me know if you think otherwise).

I have addressed the review comments and will base my next patch on this (this
patch is probably mostly the blocker for the upcoming ones).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105426/new/

https://reviews.llvm.org/D105426

Files:
  clang-tools-extra/clangd/CMakeLists.txt
  clang-tools-extra/clangd/IncludeSanity.cpp
  clang-tools-extra/clangd/IncludeSanity.h
  clang-tools-extra/clangd/unittests/CMakeLists.txt
  clang-tools-extra/clangd/unittests/IncludeSanityTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D105426.365094.patch
Type: text/x-patch
Size: 12436 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210809/b9fc122d/attachment.bin>