[PATCH] D107641: [clang-tidy] fix duplicate '{}' in cppcoreguidelines-pro-type-member-init

liushuai wang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Aug 8 23:18:04 PDT 2021


MTC added inline comments.


================
Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeMemberInitCheck.cpp:454
+
+  if (AllFieldsToInit.empty())
+    return;
----------------
MTC wrote:
> `FieldsToInit` being empty implies `AllFieldsToInit` is empty. We have checked the emptiness of `FieldsToInit`.
never mind, what I said is wrong!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107641/new/

https://reviews.llvm.org/D107641



More information about the cfe-commits mailing list