[PATCH] D105981: [AMDGPU][OpenMP] Support linking of math libraries

Jon Chesterfield via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Aug 8 14:53:59 PDT 2021


JonChesterfield added a comment.

It's been pointed out to me that -lm is a linker flag so it's weird to require it at compile time. I haven't thought of a good fix for that yet.

We don't need to splice in ocml for each compilation unit, so can move the test+splice into the link phase, except that amdgcn doesn't have a very well defined link phase as it keeps everything in IR. We could look for -c or equivalent, i.e. only check for ocml when building an executable, and not when compiling a translation unit to IR.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D105981/new/

https://reviews.llvm.org/D105981



More information about the cfe-commits mailing list