[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

Matt Jacobson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 7 02:35:30 PDT 2021


mhjacobson added a comment.

In D107684#2932609 <https://reviews.llvm.org/D107684#2932609>, @benshi001 wrote:

> In D107684#2932605 <https://reviews.llvm.org/D107684#2932605>, @mhjacobson wrote:
>
>> In D107684#2932603 <https://reviews.llvm.org/D107684#2932603>, @benshi001 wrote:
>>
>>> We need not add another `basic_avr_tree_opt_local`, since you added `/avr` to possible avr-libc pathes, you can test your change by specifying `--sysroot  %S/Inputs/basic_avr_tree/usr/lib/` .
>>
>> Oh, good idea.
>
> Sorry, only spefifying `--sysroot  %S/Inputs/basic_avr_tree/usr/lib/` does not work, since the search for avr-ld also relies on `--sysroot`.

For the purpose of the test, that doesn't matter, since we're just looking for the existence of the `-internal-isystem` argument.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107684/new/

https://reviews.llvm.org/D107684



More information about the cfe-commits mailing list