[PATCH] D107684: [NFC][AVR][clang] Add test for D107672

Ben Shi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 7 02:24:28 PDT 2021


benshi001 added a comment.

In D107684#2932605 <https://reviews.llvm.org/D107684#2932605>, @mhjacobson wrote:

> In D107684#2932603 <https://reviews.llvm.org/D107684#2932603>, @benshi001 wrote:
>
>> We need not add another `basic_avr_tree_opt_local`, since you added `/avr` to possible avr-libc pathes, you can test your change by specifying `--sysroot  %S/Inputs/basic_avr_tree/usr/lib/` .
>
> Oh, good idea.

Sorry, only spefifying `--sysroot  %S/Inputs/basic_avr_tree/usr/lib/` does not work, since the search for avr-ld also relies on `--sysroot`.

So I suggest adding a new dir name `avr` inside `Inputs/basic_avr_tree/`, and also put a copy of the fake avr-libc files at `Inputs/basic_avr_tree/avr`.

In this way the searchs for both avr-gcc and avr-libc should  work.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107684/new/

https://reviews.llvm.org/D107684



More information about the cfe-commits mailing list