[PATCH] D107682: [AVR][clang] Improve search for avr-libc installation path

Matt Jacobson via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 7 00:08:52 PDT 2021


mhjacobson added inline comments.


================
Comment at: clang/lib/Driver/ToolChains/AVR.cpp:457
+  std::string GCCRoot(GCCInstallation.getInstallPath());
+  std::string Path(GCCRoot + "/../../../avr");
+  if (llvm::sys::fs::is_directory(Path))
----------------
Would it be worth encapsulating this logic in an accessor method on GCCInstallation?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107682/new/

https://reviews.llvm.org/D107682



More information about the cfe-commits mailing list