[PATCH] D107613: [Clang][DiagnosticSemaKinds] combine diagnostic texts

Nick Desaulniers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 6 11:40:48 PDT 2021


nickdesaulniers added inline comments.


================
Comment at: clang/lib/Sema/SemaDecl.cpp:3686
+        Diag(Old->getLocation(), diag::note_previous_declaration);
+      }
 
----------------
should `CXX11NoReturnAttr` be `dropAttr` on `New` like the other cases, too?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107613/new/

https://reviews.llvm.org/D107613



More information about the cfe-commits mailing list