[PATCH] D107634: [clangd] Strip mutliple arch options

[Kadir Cetinkaya via Phabricator via cfe-commits]

kadircet marked 3 inline comments as done.
kadircet added inline comments.


================
Comment at: clang-tools-extra/clangd/CompileCommands.cpp:225
 
+  llvm::SmallVector<unsigned, 1> IndicesToDrop;
+  // Having multiple architecture options (e.g. when building FAT binaries)
----------------
sammccall wrote:
> nit: llvm::SmallVector<unsigned> unless you're very sure about the 1
I think we'll still have just the single filename in the most common case and will only have `-arch` or multiple filenames rarely. so keeping it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107634/new/

https://reviews.llvm.org/D107634