[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

Anshil Gandhi via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 5 14:03:34 PDT 2021


gandhi21299 updated this revision to Diff 364608.
gandhi21299 marked 2 inline comments as done.
gandhi21299 added a comment.

- code formatting
- @arsenm Being specific can be useful to some users. I don't see generating optimization remarks as a popular thing that every user will trigger so only those who care about it can trigger it and make something out of the info.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106891/new/

https://reviews.llvm.org/D106891

Files:
  clang/test/CodeGenCUDA/fp-atomics-optremarks.cu
  clang/test/CodeGenOpenCL/fp-atomics-optremarks-gfx90a.cl
  llvm/include/llvm/CodeGen/TargetLowering.h
  llvm/lib/CodeGen/AtomicExpandPass.cpp
  llvm/lib/Target/AMDGPU/AMDGPUISelLowering.cpp
  llvm/lib/Target/AMDGPU/AMDGPUISelLowering.h
  llvm/lib/Target/AMDGPU/SIISelLowering.cpp
  llvm/lib/Target/AMDGPU/SIISelLowering.h
  llvm/lib/Target/X86/X86ISelLowering.cpp
  llvm/lib/Target/X86/X86ISelLowering.h
  llvm/test/CodeGen/AMDGPU/fp-atomics-remarks-gfx90a.ll
  llvm/test/CodeGen/AMDGPU/llc-pipeline.ll
  llvm/test/CodeGen/X86/O0-pipeline.ll
  llvm/test/CodeGen/X86/opt-pipeline.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D106891.364608.patch
Type: text/x-patch
Size: 20920 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210805/c31366cd/attachment-0001.bin>


More information about the cfe-commits mailing list