[PATCH] D96324: [clangd] Rename references to function arguments within the same file

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 6 04:20:43 PDT 2021


kadircet added a comment.

I think this is a great use case for pseudo parser actually (unfortunately requires some multi-file interactions). In theory we can just fetch all the references, pseudo-parse the files, and update all the declarations & definitions to have the same parameter name.

My 2 cents for limiting to single-file cases initially;
It sounds like a better option to make the functionality less surprising, but I think we'll still end up confusing the users, so I am not sure if it is worth.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D96324/new/

https://reviews.llvm.org/D96324



More information about the cfe-commits mailing list