[PATCH] D107559: [clang] Fix libclang linking on Solaris

Tom Stellard via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 5 10:03:39 PDT 2021


tstellar added a comment.

In D107559#2928999 <https://reviews.llvm.org/D107559#2928999>, @ro wrote:

> In D107559#2928851 <https://reviews.llvm.org/D107559#2928851>, @tstellar wrote:
>
>> Is there any kind of comment that is supported by all linkers?
>
> Seems there isn't.  In that case, we could either move the comments to a separate file (`libclang.README`?), strip the comments when using
> Solaris `ld` (a bit ugly), or have two separate version scripts (terrible, bound to diverge).

I think it would be better to move the comments to libclang.README.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107559/new/

https://reviews.llvm.org/D107559



More information about the cfe-commits mailing list