[PATCH] D106891: [AMDGPU] [Remarks] Emit optimization remarks for FP atomics

Stanislav Mekhanoshin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 4 15:05:37 PDT 2021


rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12146
+        OptimizationRemark Remark(DEBUG_TYPE, "Passed", RMW->getFunction());
+        Remark << "A floating-point atomic instruction will generate an unsafe"
+                  " hardware instruction";
----------------
It would not necessarily generate a HW instruction. There are still cases where we return CmpXChg.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106891/new/

https://reviews.llvm.org/D106891



More information about the cfe-commits mailing list