[PATCH] D107522: [PowerPC][AIX] attribute aligned cannot decrease align of a vector var.
Sean Fertile via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Aug 5 06:17:26 PDT 2021
sfertile marked 3 inline comments as done.
sfertile added inline comments.
================
Comment at: clang/lib/Sema/SemaDeclAttr.cpp:4081
+ if (Ty->isVectorType() && AlignVal < 16)
+ return;
+ }
----------------
aaron.ballman wrote:
> This should produce a diagnostic rather than silently drop the attribute. I'd recommend `err_alignas_underaligned` if you're willing to make this an error. If not, you could add a new warning with the same wording.
Thanks for the feedback Aaron. I think an error is too drastic a difference from the other compilers on AIX so I added the warning.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107522/new/
https://reviews.llvm.org/D107522
More information about the cfe-commits
mailing list