[PATCH] D107420: [sema] Disallow __builtin_mul_overflow under special condition.

Freddy, Ye via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 5 05:15:28 PDT 2021


FreddyYe added a comment.

In D107420#2927856 <https://reviews.llvm.org/D107420#2927856>, @lebedev.ri wrote:

> I don't personally care, but i think this diag doesn't make sense.
> What is "backend"? Which one? All of them? What happens when one, but not all of them supports it?
> What if i don't intend to codegen this into an assembly, but only want to produce the IR?

THX for comment. The root cause unable to support this is same as the code added before (line 328-329). I'm suppossing we can view this patch as a supplementary patch of the old one?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107420/new/

https://reviews.llvm.org/D107420



More information about the cfe-commits mailing list