[PATCH] D106785: [C++4OpenCL] Introduces __remove_address_space utility

Anastasia Stulova via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 5 04:29:17 PDT 2021


Anastasia added inline comments.


================
Comment at: clang/docs/LanguageExtensions.rst:1964
 
+Address space removal
+---------------------
----------------
Topotuna wrote:
> Anastasia wrote:
> > Anastasia wrote:
> > > Maybe we could title it something like:
> > > 
> > > `Address space removal utility`
> > > or
> > > `Address space removal trait`
> > > ?
> > Although we could also be more specific and name it
> > `Remove address space builtin function`?
> `Builtin address space removal utility`?
> 
> I would prefer not to leave wording "Remove address space" in description because it is already what utility name says and so it adds no extra information.
Well the section name is to identify the content and not to provide extra information so the closer you are to the actual content the better. I find  `Remove address space builtin function` much more specific to the content to be honest.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106785/new/

https://reviews.llvm.org/D106785



More information about the cfe-commits mailing list