[PATCH] D107394: [AIX] "aligned" attribute does not decrease alignment

Sean Fertile via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 4 19:13:40 PDT 2021


sfertile added a comment.

Thanks Steven, LGTM.



================
Comment at: clang/test/Layout/aix-alignof-align-and-pack-attr.cpp:11
+
+// CHECK: @c = global %struct.C zeroinitializer, align 2
----------------
stevewan wrote:
> sfertile wrote:
> > Minor nit: I think the other test can live in this file, highlighting the difference between the 2 cases is nice. Also I think we should add a typedef test in here as well.
> Merged the tests as suggested. We have the typedef coverage in `aix-power-alignment-typedef.cpp` and `aix-power-alignment-typedef2.cpp`, not sure if want to merge those as well.
No need to merge those as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107394/new/

https://reviews.llvm.org/D107394



More information about the cfe-commits mailing list