[PATCH] D107492: [clang] Replace asm with __asm__ in cuda header
Jon Chesterfield via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Aug 4 15:57:31 PDT 2021
JonChesterfield added a comment.
In D107492#2926910 <https://reviews.llvm.org/D107492#2926910>, @tra wrote:
> In D107492#2926871 <https://reviews.llvm.org/D107492#2926871>, @JonChesterfield wrote:
>
>> Therefore I'd like to leave it as `__asm__ volatile`.
>
> Being the one who introduced inconsistent use of `__volatile__` and `volatile` in this header, I'm pretty sure that PTX's notion of volatile is not involved for inline asm of `trap` and `brkpt`. It should be fine changing them to `__volatile__` for the sake of uniformity.
> Up to you.
Ah, I had missed that we already had an instance of `__volatile__`. We have one `__volatile__` and three `volatile`. I like consistency and it seems you would prefer '__' to '', will patch that at the same time.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107492/new/
https://reviews.llvm.org/D107492
More information about the cfe-commits
mailing list