[PATCH] D107492: [clang] Replace asm with __asm__ in cuda header

Evgeny Mankov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 4 15:37:36 PDT 2021


emankov added inline comments.


================
Comment at: clang/lib/Headers/__clang_cuda_device_functions.h:1043
 }
-#else // CUDA_VERSION >= 9020
+#else  // CUDA_VERSION >= 9020
 // CUDA no longer provides inline assembly (or bitcode) implementation of these
----------------
JonChesterfield wrote:
> JonChesterfield wrote:
> > emankov wrote:
> > > Unneeded formatting.
> > Correct formatting though. This is what clang-format did to the whole file. I'll revert the space in favour of git-clang-format if you prefer
> git-clang-format also wanted to insert the space here and I then had to use -nolint. However hopefully that removes an async round trip in the review chain. Some of the previous lines were 81 characters. I suppose we could apply a whitespace-only clang-format patch first but it doesn't seem worth the time.
The point is that this formatting is not related to the change.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107492/new/

https://reviews.llvm.org/D107492



More information about the cfe-commits mailing list