[PATCH] D107492: [clang] Replace asm with __asm__ in cuda header

Artem Belevich via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 4 13:08:38 PDT 2021


tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

LGTM in general.



================
Comment at: clang/lib/Headers/__clang_cuda_device_functions.h:37
 #if defined(__cplusplus)
-__DEVICE__ void __brkpt() { asm volatile("brkpt;"); }
+__DEVICE__ void __brkpt() { __asm__ volatile("brkpt;"); }
 __DEVICE__ void __brkpt(int __a) { __brkpt(); }
----------------
Should we also change `volatile` ->  `__volatile__` here in other places in the file?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107492/new/

https://reviews.llvm.org/D107492



More information about the cfe-commits mailing list