[PATCH] D107304: [clangd][query-driver] Extract GCC version from the driver output

Aleksandr Platonov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 3 21:53:30 PDT 2021


ArcsinX added a comment.

In D107304#2922975 <https://reviews.llvm.org/D107304#2922975>, @kadircet wrote:

> But I am not convinced that changing the default behaviour here is going to be beneficial for majority of the users.

I think that majority of users doesn't use `--query-driver` at all.

> In other words, if we keep things as-is today, people that want a specific GNUC version can set clangd to parse their code with that specific version they know about and face the consequences if clang doesn't provide the same extensions GCC does. Or we can change the behaviour to what you propose and make people that has a broken parse to change their GNUC version to something they have no idea about (they won't know that they should set it to 4.2.1 or any other specific version).

I think that setting correct version of GCC wont' break anything for the most of users (but I do not know how to prove this), but can fix (I saw this by myself), that's why I can't agree with you =)
I bet that most of users which face the problem I described, can't solve this by their own, because of knowledge lack (nothing can be found in the documentation that can help):
Level 1: I see errors in my code with `--query-driver` specified. Why this happened?
Level 2: Ok, I know that this is because of `__GNUC__` macro definition, what should I do to make it works?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107304/new/

https://reviews.llvm.org/D107304



More information about the cfe-commits mailing list