[PATCH] D107402: Correct a lot of diagnostic wordings for the driver

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 3 14:22:48 PDT 2021


aaron.ballman created this revision.
aaron.ballman added a reviewer: erichkeane.
Herald added subscribers: phosek, jfb.
aaron.ballman requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added a subscriber: sstefan1.
Herald added a project: clang.

Clang diagnostics should not start with a capital letter or use trailing punctuation (https://clang.llvm.org/docs/InternalsManual.html#the-format-string), but quite a few driver diagnostics were not following this advice. This corrects the grammar and punctuation to improve consistency, but does not change the circumstances under which the diagnostics are produced.

(This hopefully shouldn't require a considerable amount of review, but I wanted the CI pipeline to run over the changes to hopefully catch any tests that don't run on Windows.)


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D107402

Files:
  clang/include/clang/Basic/DiagnosticDriverKinds.td
  clang/test/Driver/aix-object-mode.c
  clang/test/Driver/arm-thumb-only-cores.c
  clang/test/Driver/cl-inputs.c
  clang/test/Driver/cl-options.c
  clang/test/Driver/clang_f_opts.c
  clang/test/Driver/defsym.s
  clang/test/Driver/fuse-ld.c
  clang/test/Driver/msp430-hwmult.c
  clang/test/Driver/rocm-not-found.cl
  clang/test/Frontend/invalid-cxx-abi.cpp
  clang/test/Frontend/round-trip-cc1-args.c
  clang/test/OpenMP/target_messages.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D107402.363879.patch
Type: text/x-patch
Size: 25782 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20210803/7086a13a/attachment-0001.bin>


More information about the cfe-commits mailing list