[PATCH] D107366: [analyzer] Adjust JS code of analyzer's HTML report for IE support.
Artem Dergachev via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Aug 3 13:07:34 PDT 2021
NoQ added inline comments.
================
Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:1352-1356
+ // key 'j'
+ if (event.keyCode == 74) {
navigateTo(/*up=*/false);
- } else if (event.key == "k") {
+ // key 'k'
+ } else if (event.keyCode == 75) {
----------------
This probably also solves keyboard layout problems, nice!
================
Comment at: clang/lib/StaticAnalyzer/Core/HTMLDiagnostics.cpp:1373
+ var array = [];
+ for (var i = lower; i <= upper; ++i) {
+ array.push(i);
----------------
Shouldn't it be `i < upper`?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107366/new/
https://reviews.llvm.org/D107366
More information about the cfe-commits
mailing list