[PATCH] D106394: [clang][pp] adds '#pragma include_instead'

David Blaikie via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 3 08:12:34 PDT 2021


dblaikie added a comment.

In D106394#2921830 <https://reviews.llvm.org/D106394#2921830>, @kimgr wrote:

> Took me a while to get my head around it, but I see now that this is only supported for system headers. I think that makes sense for the compiler, otherwise it will be hard to guess which headers are allowed to include what. IWYU usually doesn't have that problem, as we analyze source files individually, and usually not headers independently.

Not sure I follow - could you describe IWYU's approach in more detail? Certainly a clang warning can be powered by examining a source file and all the includes in totality, not only using local reasoning at the location of one #include from another file. So if there's a way to use more global (within the scope of a single translation unit) reasoning to get a more general purpose feature, that would be an option.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106394/new/

https://reviews.llvm.org/D106394



More information about the cfe-commits mailing list