[PATCH] D106343: [OpenCL] Support cl_ext_float_atomics

Tue Aug 3 05:12:59 PDT 2021

Anastasia added a comment.

Just to make sure you are aware Clang doesn't use this header by default, so the upstream users won't be able to call those functions unless you add them into `OpenCLBuiltins.td`:
https://clang.llvm.org/docs/OpenCLSupport.html#opencl-builtins

This header is only accessible via the frontend options: https://clang.llvm.org/docs/OpenCLSupport.html#cmdoption-finclude-default-header

================
Comment at: clang/lib/Headers/opencl-c.h:13435
+                                       memory_scope scope);
+#endif
+#if defined(__opencl_c_ext_fp32_local_atomic_min_max)
----------------
Can you annotate the `#endif`s with a comment describing what they correspond to. i.e. something like:

```
#endif //defined(__opencl_c_ext_fp32_global_atomic_min_max)
```

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D106343/new/

https://reviews.llvm.org/D106343